Respond to comments

common/constants.go

@@ -309,3 +309,7 @@ const (
 	ShardModeHashRing         = "hash-ring"
 	ShardModeShardDistributor = "shard-distributor"
 )
+
+const (
+	StringSizeOverheadBytes = 16
+)

common/definition/workflowIdentifier.go

@@ -20,6 +20,8 @@
 
 package definition
 
+import "github.com/uber/cadence/common"
+
 type (
 	// WorkflowIdentifier is the combinations which represent a workflow
 	WorkflowIdentifier struct {
@@ -34,7 +36,7 @@ func (wi *WorkflowIdentifier) Size() uint64 {
 	// Calculate the size of strings in bytes, we assume that all those fields are using ASCII which is 1 byte per char
 	size := len(wi.DomainID) + len(wi.WorkflowID) + len(wi.RunID)
 	// Each string internally holds a reference pointer and a length, which are 8 bytes each
-	stringOverhead := 3 * 16
+	stringOverhead := 3 * common.StringSizeOverheadBytes
 	return uint64(size + stringOverhead)
 }
 

service/history/execution/context.go

@@ -1394,6 +1394,7 @@ func (c *contextImpl) Size() uint64 {
 	size += len(c.domainID)
 
 	size += len(c.workflowExecution.GetWorkflowID()) + len(c.workflowExecution.GetRunID())
+	size += 3 * common.StringSizeOverheadBytes
 	size += int(c.shard.Size())
 
 	size += 3 * 8 // logger