Created a seperate listWithRing for services that has a hashring (cad…

…ence-workflow#6350)

What changed?
Created a seperate list of services that has a hashring.
Use the new list in places where we assume services has a hashring

Why?
We assumed in a few places that all services has a hash ring. Shard manager does not have a hash ring, and we do not want to create one.

How did you test it?
Unit tests, and local manual testing

Potential risks

Release notes

Documentation Changes

common/membership/resolver.go

@@ -98,12 +98,7 @@ func NewResolver(
 	logger log.Logger,
 	metrics metrics.Client,
 ) (*MultiringResolver, error) {
-	return NewMultiringResolver([]string{
-		service.Frontend,
-		service.Worker,
-		service.Matching,
-		service.History,
-	}, provider, logger.WithTags(tag.ComponentServiceResolver), metrics), nil
+	return NewMultiringResolver(service.ListWithRing, provider, logger.WithTags(tag.ComponentServiceResolver), metrics), nil
 }
 
 // NewMultiringResolver creates hashrings for all services

common/service/name.go

@@ -37,6 +37,9 @@ const (
 	ShardManager = "cadence-shard-manager"
 )
 
+// ListWithRing contains the list of all cadence services that has a hash ring
+var ListWithRing = []string{Frontend, History, Matching, Worker}
+
 // List contains the list of all cadence services
 var List = []string{Frontend, History, Matching, Worker, ShardManager}
 

service/frontend/admin/handler.go

@@ -876,7 +876,7 @@ func (adh *adminHandlerImpl) DescribeCluster(
 		}
 
 		var rings []*types.RingInfo
-		for _, role := range service.List {
+		for _, role := range service.ListWithRing {
 			var servers []*types.HostInfo
 			members, err := monitor.Members(role)
 			if err != nil {