change execution-cache to sized-based cache implementation

timl3136 · Feb 14, 2025 · e28eb59 · e28eb59
1 parent 4b30b13
commit e28eb59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/service/history/execution/cache.go b/service/history/execution/cache.go
@@ -24,6 +24,7 @@ package execution
 
 import (
 	"context"
+	"reflect"
 	"sync/atomic"
 	"time"
 
@@ -108,14 +109,21 @@ const (
 	cacheReleased    int32 = 1
 )
 
+// GetCacheItemSize returns the size of interface{} using reflect
+func GetCacheItemSize(i interface{}) uint64 {
+	return uint64(reflect.TypeOf(i).Size())
+}
+
 // NewCache creates a new workflow execution context cache
 func NewCache(shard shard.Context) Cache {
 	opts := &cache.Options{}
 	config := shard.GetConfig()
 	opts.InitialCapacity = config.HistoryCacheInitialSize()
 	opts.TTL = config.HistoryCacheTTL()
 	opts.Pin = true
-	opts.MaxCount = config.HistoryCacheMaxSize()
+	opts.MaxSize = uint64(config.HistoryCacheMaxSize())
+
+	opts.GetCacheItemSizeFunc = GetCacheItemSize
 
 	return &cacheImpl{
 		Cache:            cache.New(opts),

diff --git a/service/history/execution/cache_test.go b/service/history/execution/cache_test.go
@@ -121,7 +121,7 @@ func (s *historyCacheSuite) TestHistoryCacheBasic() {
 }
 
 func (s *historyCacheSuite) TestHistoryCachePinning() {
-	s.mockShard.GetConfig().HistoryCacheMaxSize = dynamicconfig.GetIntPropertyFn(2)
+	s.mockShard.GetConfig().HistoryCacheMaxSize = dynamicconfig.GetIntPropertyFn(10)
 	domainID := "test_domain_id"
 	s.cache = NewCache(s.mockShard)
 	we := types.WorkflowExecution{