Ensure maximum compatibility with mdx-bundler #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdx-bundler doesn't document usage without its client entrypoint. This replaces the custom implementation of `getMDXComponent` with the one exported by `mdx-bundler/client`. We're using this patch at Vercel in nextjs.org already.
eps1lon
force-pushed
the
mdx-bundler-compat
branch
from
6df8467
to
ab5b962
Compare
|
How reliable are these Windows runs? Can't see any change that would only break on Windows but pass on Linux and macOS. |
It's an existing issue with Contentlayer and unrelated to this PR. The fix looks good to me, thanks! |
This was referenced Aug 28, 2024
This was referenced Sep 7, 2024
This was referenced Sep 14, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdx-bundler doesn't document usage without its client entrypoint. This replaces the custom implementation of
getMDXComponentwith the one exported bymdx-bundler/client. Otherwise changes such as kentcdodds/mdx-bundler#229 would breaknext-contentlayer.We're using this patch at Vercel in nextjs.org already.