Skip to content

Conversation

@abernier
Copy link
Contributor

@abernier abernier commented Jul 7, 2024

READY TO MERGE

Provide a default pages.yml workflow that automatically deploys on GitHub Pages (if enabled in settings)

with the right basePath automatically

Demo: https://github.com/abernier/tailwind-nextjs-starter-blog/actions/runs/9870682135

  • replace testing-purpose values
  • Updated doc

@vercel
Copy link

vercel bot commented Jul 7, 2024

@abernier is attempting to deploy a commit to the timlrx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@abernier abernier marked this pull request as draft July 7, 2024 15:33
@abernier abernier force-pushed the pages branch 8 times, most recently from b77f3ed to 4dd23de Compare July 8, 2024 15:52
@abernier abernier changed the title gh pages workflow reusable gh-pages workflow Jul 8, 2024
@abernier abernier changed the title reusable gh-pages workflow reusable gh-pages workflow (Jekyll like) Jul 8, 2024
@abernier abernier marked this pull request as ready for review July 8, 2024 17:48
@abernier abernier force-pushed the pages branch 5 times, most recently from 9a58aa1 to 247a157 Compare July 8, 2024 21:51
next.config.js Outdated
Comment on lines +57 to +59
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined at build time (by the workflow): undefined otherwise (inert)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice approach

@abernier abernier changed the title reusable gh-pages workflow (Jekyll like) reusable action (Jekyll like) Jul 8, 2024
@abernier abernier force-pushed the pages branch 6 times, most recently from 2f6e744 to 898af2b Compare July 9, 2024 06:51
@abernier abernier force-pushed the pages branch 3 times, most recently from cef8c7d to 1cf3fed Compare July 9, 2024 07:24
@abernier abernier changed the title reusable action (Jekyll like) generator + pages workflow Jul 9, 2024
@abernier abernier changed the title generator + pages workflow pages action workflow Jul 10, 2024
@abernier abernier changed the title pages action workflow Pages custom Actions workflow Jul 10, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basePath from actions/configure-pages@v5 🥳

@vercel
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-nextjs-starter-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 1:50pm

@timlrx
Copy link
Owner

timlrx commented Jul 10, 2024

Thanks! This greatly simplifies deploying to Github pages out of the box and also thanks for updating the readme. Let's give it a try!

@timlrx timlrx merged commit 13563ff into timlrx:main Jul 10, 2024
@abernier
Copy link
Contributor Author

abernier commented Jul 10, 2024

do not hesitate to enable it in project's settings ;)

nb: then, could be great adding a link to https://timlrx.github.io/tailwind-nextjs-starter-blog in the readme ;)

@timlrx
Copy link
Owner

timlrx commented Jul 10, 2024

I have merged it in and almost everything works except for the cmd-k search. I believe it is probably a base path issue. Do you mind taking a look and once you are done, you can also include the demo link in the doc: https://timlrx.github.io/tailwind-nextjs-starter-blog/

@abernier
Copy link
Contributor Author

except for the cmd-k search

#962 fixes this

bhiwagade-rahul pushed a commit to bhiwagade-rahul/tailwind-nextjs-starter-blog that referenced this pull request Sep 22, 2025
Pages custom Actions workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants