-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Pages custom Actions workflow #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@abernier is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
b77f3ed to
4dd23de
Compare
9a58aa1 to
247a157
Compare
next.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defined at build time (by the workflow): undefined otherwise (inert)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a nice approach
2f6e744 to
898af2b
Compare
cef8c7d to
1cf3fed
Compare
.github/workflows/pages.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basePath from actions/configure-pages@v5 🥳
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks! This greatly simplifies deploying to Github pages out of the box and also thanks for updating the readme. Let's give it a try! |
|
do not hesitate to enable it in project's settings ;) nb: then, could be great adding a link to https://timlrx.github.io/tailwind-nextjs-starter-blog in the readme ;) |
|
I have merged it in and almost everything works except for the cmd-k search. I believe it is probably a base path issue. Do you mind taking a look and once you are done, you can also include the demo link in the doc: https://timlrx.github.io/tailwind-nextjs-starter-blog/ |
#962 fixes this |
Pages custom Actions workflow
READY TO MERGE
Provide a default
pages.ymlworkflow that automatically deploys on GitHub Pages (if enabled in settings)with the right
basePathautomaticallyDemo: https://github.com/abernier/tailwind-nextjs-starter-blog/actions/runs/9870682135