Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge_tags duplication #10

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: merge_tags duplication #10

merged 1 commit into from
Mar 24, 2023

Conversation

fredericbonnet
Copy link
Contributor

PR #9 introduced a bug where tags from parent dirs were duplicated when merged in child pages. This PR fixes the issue by making a copy of the tag array before extending it

@fredericbonnet fredericbonnet marked this pull request as ready for review March 24, 2023 12:27
@fredericbonnet fredericbonnet mentioned this pull request Mar 24, 2023
Merged
@timmeinerzhagen timmeinerzhagen changed the title Main fix: merge_tags duplication Mar 24, 2023
timmeinerzhagen
timmeinerzhagen approved these changes Mar 24, 2023
View reviewed changes
Copy link
Owner

@timmeinerzhagen timmeinerzhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@timmeinerzhagen timmeinerzhagen merged commit 193f4f2 into timmeinerzhagen:main Mar 24, 2023
@timmeinerzhagen
Copy link
Owner

Released in v0.2.1 / PyPi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmeinerzhagen timmeinerzhagen timmeinerzhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericbonnet @timmeinerzhagen