-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new Docker setup with s6-overlay #193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
ghost
locked as resolved and limited conversation to collaborators
Feb 11, 2019
timmo001
added a commit
that referenced
this pull request
Sep 22, 2019
Fixes #193 * ✨ ⛵ Create new Docker setup with s6-overlay * 👕 Fix errors * 🔨 remove jq * 🔨 Add missing argument * 🔨 Cleanup * 🔨 Copy built app * 🔥 Fix build path * 🔨 remove stage not required * 🚑 Add missing mime types * 🔨 Create nicer default file * 🔨 tweak default file * 🔨 Remove test * ⛵ Update docker-compose file * 🔨 Fix docker-compose volumes * 📚 Update docs for new setup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrites Dockerfile to use s6-overlay and shrinks image size down as much as possible.
Related issues this fixes
#188
TODO
Checklist