Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pinchAndPan option to enable panning during pinch zoom #607

Merged
merged 1 commit into from
May 17, 2022

Conversation

timmywil
Copy link
Owner

@timmywil timmywil commented Jan 28, 2022

Ref gh-512
Fixes gh-606

PR Checklist

Please review the guidelines for contributing to this repository.

  • I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not main.
  • I have run yarn test against my changes and tests pass.
  • I have added tests to prove my fix is effective or my feature works. This can be done in the form of unit tests in test/unit/ or a new or altered demo in demo/.
  • I have added or edited necessary types and generated documentation (yarn docs), or no docs changes are needed.

Description

Panning during pinch zoom was removed in 4.4.1 to fix #512. But that is technically a change in behavior and should have been done in a major version. To that end, I've added back the behavior here as an option (pinchAndPan: true) that can be passed to re-enable the behavior. I'm currently testing to see if I can get it to work with the original issue.

@timmywil timmywil marked this pull request as ready for review February 7, 2022 16:14
@spacecowgoesmoo spacecowgoesmoo mentioned this pull request May 17, 2022
@timmywil timmywil merged commit f5bc3ac into main May 17, 2022
@timmywil timmywil deleted the feature/pinchnpan branch May 17, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinch and pan simultaneously Pinch zoom moves image away from screen center
1 participant