Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detecting TypeScript default lib files #48

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Conversation

timocov
Copy link
Owner

@timocov timocov commented Jun 27, 2018

Fixes #39

@timocov
Copy link
Owner Author

timocov commented Jun 27, 2018

@rhuitl please check this PR and confirm that it fixes your issue.

@timocov timocov changed the title Fix detect TypeScript default lib files Fix detecting TypeScript default lib files Jun 27, 2018
@rhuitl
Copy link

rhuitl commented Jun 28, 2018

Hmm, when I tried to test this PR, I discovered that simply by installing typescript@next the issue from #39 seems to be fixed - even without this PR:

  "devDependencies": {
    "dts-bundle-generator": "^1.5.0",
    "typescript": "^3.0.0-dev.20180628"
  }

@rhuitl
Copy link

rhuitl commented Jun 28, 2018

On the other hand, dts-bundle-generator from this PR together with TypeScript 2.9.2 solve #39, as well. Thanks :)

@timocov
Copy link
Owner Author

timocov commented Jun 28, 2018

I discovered that simply by installing typescript@next the issue from #39 seems to be fixed - even without this PR

Hm, that's interesting - I'll check what is changed in the new version.

dts-bundle-generator from this PR together with TypeScript 2.9.2 solve #39, as well

That's nice, thanks! I'll merge it and release soon.

@timocov
Copy link
Owner Author

timocov commented Jun 29, 2018

It seems that it was fixed in microsoft/TypeScript#23893.

@timocov timocov merged commit e1f41aa into master Jun 29, 2018
@timocov timocov deleted the fix_detect_ts_lib_files branch June 29, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants