Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toast.dimiss #50

Closed
gr-qft opened this issue Feb 24, 2021 · 1 comment · Fixed by #53
Closed

toast.dimiss #50

gr-qft opened this issue Feb 24, 2021 · 1 comment · Fixed by #53
Labels
bug Something isn't working

Comments

@gr-qft
Copy link
Contributor

gr-qft commented Feb 24, 2021

Thanks for this great library!

I think this is more like a question. When toast.dismiss is called, a toast is dismissed after 1s, but if a new toast is created fast enough after dismissed is called, the toast will be dismissed almost immediately. Should creating a new toast be disabled while the dismissing animation is still in effect?
@timolins timolins added the bug Something isn't working label Feb 24, 2021
@timolins
Copy link
Owner

Great catch, this seems to be a bug. The remove timeout is not getting cleared when a new toast with the same ID is dispatched.

timolins added a commit that referenced this issue Mar 1, 2021
@timolins
Keep track of dismissed toasts
176bc05 
Store timeouts of dismissed toasts.
This should prevent toasts from beeing removed, after re-dispatched with the same ID.

Fixes #50
@timolins timolins mentioned this issue Mar 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep track of dismissed toasts timolins/react-hot-toast
2 participants
@timolins @gr-qft