Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csstype peer dep #183

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

eeston
Copy link
Contributor

@eeston eeston commented May 11, 2022

Small change to fix this issue.

This release contained the fix for the missing peer dependency.

@vercel
Copy link

vercel bot commented May 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-hot-toast ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 6:48PM (UTC)

@timolins
Copy link
Owner

timolins commented May 21, 2022

Thanks a lot for the PR. Before I merge, I have to check the dev setup. For some reasons, I had troubles using a v2 lockfile, which caused the Next.js site to break.

This is long overdue so I think this is the sign to tacke it.

@eeston
Copy link
Contributor Author

eeston commented May 23, 2022

@timolins I believe you need to be on npm v7 or higher for the new lockfile.

In hindsight, I probably shouldn't have included that change. Would you like me to drop the commit & push a change with a v1 lockfile?

@timolins
Copy link
Owner

That would be great for now. I just opened an issue explaining why I've been using an old NPM version: #186

I'll do some more digging, maybe I can get it resolved.

@eeston eeston force-pushed the fix/csstype-peer-dep branch from f0e1c5d to 30bdaf5 Compare June 12, 2022 18:46
@eeston
Copy link
Contributor Author

eeston commented Jun 12, 2022

Apologies for the delay. I dropped the commit containing the v2 lockfile changes :)

@grunklejp
Copy link

TY for doing this! Us clean install purists would love this merged :)

@timolins timolins merged commit 4a34354 into timolins:main Jun 15, 2022
kodiakhq bot referenced this pull request in cloudquery/cloudquery Sep 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [react-hot-toast](https://togithub.com/timolins/react-hot-toast) | dependencies | minor | [`2.1.1` -> `2.3.0`](https://renovatebot.com/diffs/npm/react-hot-toast/2.1.1/2.3.0) |

---

### Release Notes

<details>
<summary>timolins/react-hot-toast</summary>

### [`v2.3.0`](https://togithub.com/timolins/react-hot-toast/releases/tag/v2.3.0)

[Compare Source](https://togithub.com/timolins/react-hot-toast/compare/v2.2.0...v2.3.0)

#### Better bundle setup

This release focuses on build and bundle improvements (faster, lighter & better).

-   Expose `react-hot-toast/headless` - for headless environments like react-native
-   Bundle is now 15% (5% gzipped) smaller
-   Bonus: 3x faster dev builds

##### What's Changed

-   Improve dev setup (`pnpm`, update deps) by [@&#8203;timolins](https://togithub.com/timolins) in [https://github.com/timolins/react-hot-toast/pull/203](https://togithub.com/timolins/react-hot-toast/pull/203)
-   New bundler setup (tsup instead of tsdx) with `react-hot-toast/headless` by [@&#8203;timolins](https://togithub.com/timolins) in [https://github.com/timolins/react-hot-toast/pull/205](https://togithub.com/timolins/react-hot-toast/pull/205)
-   Website Example: Make snippet consistent with action by [@&#8203;diksown](https://togithub.com/diksown) in [https://github.com/timolins/react-hot-toast/pull/196](https://togithub.com/timolins/react-hot-toast/pull/196)
-   Docs: update version 2 page custom render api code example  by [@&#8203;AnishDe12020](https://togithub.com/AnishDe12020) in [https://github.com/timolins/react-hot-toast/pull/175](https://togithub.com/timolins/react-hot-toast/pull/175)
-   fix: csstype peer dep by [@&#8203;eeston](https://togithub.com/eeston) in [https://github.com/timolins/react-hot-toast/pull/183](https://togithub.com/timolins/react-hot-toast/pull/183)
-   Site Docs: 'one' => 'once' :) by [@&#8203;cbserra](https://togithub.com/cbserra) in [https://github.com/timolins/react-hot-toast/pull/201](https://togithub.com/timolins/react-hot-toast/pull/201)
-   Website Example: Make snippet consistent with action by [@&#8203;diksown](https://togithub.com/diksown) in [https://github.com/timolins/react-hot-toast/pull/196](https://togithub.com/timolins/react-hot-toast/pull/196)

##### New Contributors

-   [@&#8203;AnishDe12020](https://togithub.com/AnishDe12020) made their first contribution in [https://github.com/timolins/react-hot-toast/pull/175](https://togithub.com/timolins/react-hot-toast/pull/175)
-   [@&#8203;eeston](https://togithub.com/eeston) made their first contribution in [https://github.com/timolins/react-hot-toast/pull/183](https://togithub.com/timolins/react-hot-toast/pull/183)
-   [@&#8203;cbserra](https://togithub.com/cbserra) made their first contribution in [https://github.com/timolins/react-hot-toast/pull/201](https://togithub.com/timolins/react-hot-toast/pull/201)
-   [@&#8203;diksown](https://togithub.com/diksown) made their first contribution in [https://github.com/timolins/react-hot-toast/pull/196](https://togithub.com/timolins/react-hot-toast/pull/196)

**Full Changelog**: timolins/react-hot-toast@v2.2.0...v2.3.0

### [`v2.2.0`](https://togithub.com/timolins/react-hot-toast/releases/tag/v2.2.0)

[Compare Source](https://togithub.com/timolins/react-hot-toast/compare/v2.1.1...v2.2.0)

##### Changes

-   Expose core types  [`70dbbb2`](https://togithub.com/timolins/react-hot-toast/commit/70dbbb2)
-   Update goober  [`1563b56`](https://togithub.com/timolins/react-hot-toast/commit/1563b56)
-   Preserve line breaks in toast body Closes [#&#8203;144](https://togithub.com/timolins/react-hot-toast/issues/144)  [`f981e45`](https://togithub.com/timolins/react-hot-toast/commit/f981e45)

##### Docs

-   Fix example in docs  [`09ded7f`](https://togithub.com/timolins/react-hot-toast/commit/09ded7f)
-   Fix typo  [`379cf3e`](https://togithub.com/timolins/react-hot-toast/commit/379cf3e)
-   Add missing import to example  [`fbb2612`](https://togithub.com/timolins/react-hot-toast/commit/fbb2612)
-   Fix typo in Toaster page  [`c93328a`](https://togithub.com/timolins/react-hot-toast/commit/c93328a)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODUuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE4NS4zIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ppnm missing peer dependencies csstype@^3.0.10
3 participants