Read unknown fields even on empty messages (#670)

timostamm · Jan 29, 2025 · 326fc6d · 326fc6d
1 parent 8a508df
commit 326fc6d
Showing 1 changed file with 0 additions and 15 deletions.
diff --git a/packages/plugin/src/message-type-extensions/internal-binary-read.ts b/packages/plugin/src/message-type-extensions/internal-binary-read.ts
@@ -34,21 +34,6 @@ export class InternalBinaryRead implements CustomMethodGenerator {
     make(source: TypescriptFile, descriptor: DescriptorProto): ts.MethodDeclaration[] {
         const methods: ts.MethodDeclaration[] = [];
 
-        // if the message has no fields, we produce a much shorter body:
-        // return target ?? this.create();
-        if (descriptor.field.length === 0) {
-            return [this.makeMethod(source, descriptor,
-                ts.createReturn(ts.createBinary(
-                    ts.createIdentifier("target"),
-                    ts.createToken(ts.SyntaxKind.QuestionQuestionToken),
-                    ts.createCall(
-                        ts.createPropertyAccess(ts.createThis(), ts.createIdentifier("create")),
-                        undefined, []
-                    )
-                ))
-            )];
-        }
-
         // internalBinaryRead(reader: IBinaryReader, length: number, options: BinaryReadOptions, target?: ${messageInterfaceId}): ${messageInterfaceId} {
         let internalBinaryRead = this.makeMethod(
             source,