Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RTLD_NODELETE for loading the library #14

Closed
kvark opened this issue Feb 23, 2021 · 3 comments
Closed

Use RTLD_NODELETE for loading the library #14

kvark opened this issue Feb 23, 2021 · 3 comments

Comments

@kvark
Copy link

kvark commented Feb 23, 2021

See discussion around gfx-rs/wgpu#246 (comment)
@timothee-haudebourg
Copy link
Owner

That's unfortunate. I'll add the flag then.

The relevant issue is nagisa/rust_libloading#41

@kvark
Copy link
Author

kvark commented Feb 24, 2021

Could you clarify why this is unfortunate? Sorry, I didn't dig into all the context here.

@Aaron1011
Copy link

@kvark: The root cause of nagisa/rust_libloading#41 is this glibc bug. Ideally, you would be able to dlclose a shared library when you're done using it, and glibc would take care of removing any TLS destructors from that library.

Aaron1011 added a commit to Aaron1011/gfx that referenced this issue Feb 25, 2021
@Aaron1011
Bump khronos-egl dependency to version 4
a3385a3 
This pulls in a fix for timothee-haudebourg/khronos-egl#14,
which prevents segfaults when using this crate from another thread
(e.g. gfx-rs/wgpu#246)
@Aaron1011 Aaron1011 mentioned this issue Feb 25, 2021
Merged
3 tasks
bors bot added a commit to gfx-rs/gfx that referenced this issue Feb 25, 2021
@bors @Aaron1011
Merge #3653
0a201d1 
3653: Bump `khronos-egl` dependency to version 4 r=kvark a=Aaron1011

This pulls in a fix for timothee-haudebourg/khronos-egl#14,
which prevents segfaults when using this crate from another thread
(e.g. gfx-rs/wgpu#246)


PR checklist:
- [X] `make` succeeds (on *nix)
- [X] `make reftests` succeeds
- [X] tested examples with the following backends:
  - GL


Co-authored-by: Aaron Hill <aa1ronham@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @Aaron1011 @timothee-haudebourg