Skip to content

Commit

Permalink
EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
Browse files Browse the repository at this point in the history
  • Loading branch information
nreese authored and timroes committed Jun 19, 2018
1 parent 3006e66 commit 33995d8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/functional/apps/visualize/_input_control_vis.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export default function ({ getService, getPageObjects }) {
});
});

describe('nested controls', () => {
describe('chained controls', () => {

before(async () => {
await PageObjects.common.navigateToUrl('visualize', 'new');
Expand Down
5 changes: 3 additions & 2 deletions test/functional/page_objects/visualize_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,15 @@ export function VisualizePageProvider({ getService, getPageObjects }) {

async clearComboBox(comboBoxSelector) {
const comboBox = await testSubjects.find(comboBoxSelector);
const clearBtn = await comboBox.findByCssSelector('button.euiFormControlLayoutClearButton');
const clearBtn = await comboBox.findByCssSelector('[data-test-subj="comboBoxClearButton"]');
await clearBtn.click();
await this.closeComboBoxOptionsList(comboBox);
}

async closeComboBoxOptionsList(comboBoxElement) {
const isOptionsListOpen = await testSubjects.exists('comboBoxOptionsList');
if (isOptionsListOpen) {
const closeBtn = await comboBoxElement.findByCssSelector('button.euiFormControlLayoutCustomIcon');
const closeBtn = await comboBoxElement.findByCssSelector('[data-test-subj="comboBoxToggleListButton"]');
await closeBtn.click();
}
}
Expand Down

0 comments on commit 33995d8

Please sign in to comment.