-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare_iso disable flags #46
prepare_iso disable flags #46
Conversation
Thanks for taking the time to narrow down the culprit in #43. I think this is helpful to have as a configurable option anyway. It'd be nice if there were a clean way to do this via the template instead but I don't think there's enough "infrastructure" in the build process for that right now, so your solution is totally fine. It's been a while since I looked into the steps to automatically enable ARD via means other than Speaking as someone who uses ARD for some of the tasks for which it was designed (and loathes using it), if someone is using this repo they probably have pretty different needs. I'm going to do a couple run-throughs with a Fusion build to verify but looks great! |
Yeah, that's my understanding as well re Screen Sharing still being around. It's also possible to attach a background VM (like one Vagrant starts) to a screen session in VirtualBox 5.0 now—just launch the main UI and hit Show. |
One other bit we can omit if The condition above the dscl stuff could be moved down so that this is all done in one block. |
Sounds good. I’ll add that this evening (handful of hours from now). |
I moved the ARD permission grants under the flag, built and tested. Everything's working over here, including being able to attach via VNC to Screen Sharing without Remote Management on. |
Great. Thanks for keeping the VirtualBox support cared-and-fed-for! |
This PR adds disable flags for Screen Sharing and Remote Management, the latter of which is currently required by #43 for VirtualBox to operate successfully.
The flag mechanism should be generally useful to selectively disable or enable additional features in the built DMG.