Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare_iso disable flags #46

Merged
merged 3 commits into from
Nov 10, 2015
Merged

prepare_iso disable flags #46

merged 3 commits into from
Nov 10, 2015

Conversation

mattieb
Copy link
Contributor

@mattieb mattieb commented Nov 8, 2015

This PR adds disable flags for Screen Sharing and Remote Management, the latter of which is currently required by #43 for VirtualBox to operate successfully.

The flag mechanism should be generally useful to selectively disable or enable additional features in the built DMG.

@timsutton
Copy link
Owner

Thanks for taking the time to narrow down the culprit in #43. I think this is helpful to have as a configurable option anyway.

It'd be nice if there were a clean way to do this via the template instead but I don't think there's enough "infrastructure" in the build process for that right now, so your solution is totally fine.

It's been a while since I looked into the steps to automatically enable ARD via means other than kickstart, and I forget exactly what piece having /private/etc/RemoteManagement.launchd was a part of it. But if I understand correctly from #43, if anyone wants basic Screen Sharing enabled they can still set -D DISABLE_REMOTE_MANAGEMENT and just not have the ARD support, but still be able to connect via standard screen sharing with an IP.

Speaking as someone who uses ARD for some of the tasks for which it was designed (and loathes using it), if someone is using this repo they probably have pretty different needs.

I'm going to do a couple run-throughs with a Fusion build to verify but looks great!

@mattieb
Copy link
Contributor Author

mattieb commented Nov 9, 2015

Yeah, that's my understanding as well re Screen Sharing still being around. It's also possible to attach a background VM (like one Vagrant starts) to a screen session in VirtualBox 5.0 now—just launch the main UI and hit Show.

@timsutton
Copy link
Owner

One other bit we can omit if DISABLE_REMOTE_MANAGEMENT is set:

https://github.com/zigg/osx-vm-templates/blob/39131584e81c5acbdef1471c1ca6b187b118a2e7/prepare_iso/support/pkg-postinstall#L45-L47

The condition above the dscl stuff could be moved down so that this is all done in one block.

@mattieb
Copy link
Contributor Author

mattieb commented Nov 9, 2015

Sounds good. I’ll add that this evening (handful of hours from now).

@mattieb
Copy link
Contributor Author

mattieb commented Nov 10, 2015

I moved the ARD permission grants under the flag, built and tested. Everything's working over here, including being able to attach via VNC to Screen Sharing without Remote Management on.

@timsutton
Copy link
Owner

Great. Thanks for keeping the VirtualBox support cared-and-fed-for!

timsutton added a commit that referenced this pull request Nov 10, 2015
@timsutton timsutton merged commit 90575a7 into timsutton:master Nov 10, 2015
@mattieb mattieb deleted the prepare_iso_disable_flags branch November 16, 2015 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants