Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Group albums into artists regardless of artist name capitalisation #498

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

whimsicalities
Copy link

@whimsicalities whimsicalities commented May 21, 2020

This discards capitalisation when making a list of AlbumArtists, stopping it from separating inconsistent artists into several AlbumArtists. It will still show the correct capitalisation on the display.
I also included the update to the glide version that was causing the build to fail.
closes #497 closes #491

@CLAassistant
Copy link

CLAassistant commented May 21, 2020

CLA assistant check
All committers have signed the CLA.

@timusus
Copy link
Owner

timusus commented Jun 14, 2020

I'll have to review this one in depth, as I'm not sure what the consequences of this change are.

@pangteypiyush
Copy link

I second this. This will group artists like Tesseract (often stylized as TesseracT) into one.

@illdeletethis
Copy link

this would be a disadvantage if you are careful with your tagging, but have more than one artist with the same name that you are trying to order through different capitalization.
if added, this would be best to leave optional

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants