why does timeago type need cloudflare

[FarisZR]

hi, i have noticed that when using type: timeago it requests js files from cdnjs.cloudflare.com.
could this be replaced with local files? is this really necessary ?

[timvink]

Hi @fareszr ,

You observation is right, when using type: timeago we need to insert the timeago javascript library in order to be able to render the date dynamically

mkdocs-git-revision-date-localized-plugin/mkdocs_git_revision_date_localized_plugin/plugin.py

Lines 160 to 163 in c53dea5

	# Insert timeago.js dependencies
	extra_js = """
	<script src="https://cdnjs.cloudflare.com/ajax/libs/timeago.js/4.0.0-beta.2/timeago.min.js"></script>
	<script src="https://cdnjs.cloudflare.com/ajax/libs/timeago.js/4.0.0-beta.2/timeago.locales.min.js"></script>

could this be replaced with local files?

Yes, it could be.

is this really necessary ?

The timeago.js library is really necessary, but using a CDN isn't.

I agree local files files would be better, so the plugin works locally without internet.

[FarisZR]

Hi @fareszr ,

You observation is right, when using type: timeago we need to insert the timeago javascript library in order to be able to render the date dynamically

mkdocs-git-revision-date-localized-plugin/mkdocs_git_revision_date_localized_plugin/plugin.py

Lines 160 to 163 in c53dea5

	# Insert timeago.js dependencies
	extra_js = """
	<script src="https://cdnjs.cloudflare.com/ajax/libs/timeago.js/4.0.0-beta.2/timeago.min.js"></script>
	<script src="https://cdnjs.cloudflare.com/ajax/libs/timeago.js/4.0.0-beta.2/timeago.locales.min.js"></script>

could this be replaced with local files?

Yes, it could be.

is this really necessary ?

The timeago.js library is really necessary, but using a CDN isn't.

I agree local files files would be better, so the plugin works locally without internet.

Would like to have an oprion to add the files in the mkdocs config

[timvink]

This should be the default behaviour, I don't see a use-case why you would prefer a CDN over local files?

[timvink]

Released v.0.7.3 that addresses this.

[FarisZR]

thanks!