fix(next-tinacms-github): sends 500 with message if signing key is mi…

…ssing

packages/next-tinacms-github/src/github/proxy.test.ts

@@ -0,0 +1,31 @@
+import { apiProxy } from './proxy'
+
+describe('apiProxy', () => {
+ describe('without a signing key', () => {
+ it('responds with status 500', async () => {
+ // @ts-ignore That's the point of the test.
+ const handler = apiProxy(undefined)
+ const req = {}
+ const res = new ResStub()
+
+ await handler(req, res)
+
+ expect(res.status).toHaveBeenCalledWith(500)
+ })
+ it('sends JSON response', async () => {
+ // @ts-ignore That's the point of the test.
+ const handler = apiProxy(undefined)
+ const req = {}
+ const res = new ResStub()
+
+ await handler(req, res)
+
+ expect(res.json).toHaveBeenCalled()
+ })
+ })
+})
+
+class ResStub {
+ status = jest.fn(() => this)
+ json = jest.fn()
+}

packages/next-tinacms-github/src/github/proxy.ts

@@ -20,6 +20,12 @@ import { AES, enc } from 'crypto-js'
 import axios from 'axios'
 
 export const apiProxy = (signingKey: string) => (req: any, res: any) => {
+ if (!signingKey) {
+ return res.status(500).json({
+ message:
+ 'next-tinacms-github: the apiProxy was created without a signing key.',
+ })
+ }
  const { headers, ...data } = JSON.parse(req.body)
 
  // Parse out the amalgamated token