Scaffold: Only return compatible compiler versions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
bug/fetch-compiler-versions
branch
from
69a856e to
2565e31
Compare
If Typelevel Scala 2.12.4 is used along with Scala.js, the latest compiler version could not be determined during `seed update`: ``` Platform compiler versions ╭────────────┬──────────────┬──────────┬────────────────────────╮ │ Platform │ Organisation │ Compiler │ Version │ ├────────────┼──────────────┼──────────┼────────────────────────┤ │ JVM │ Typelevel │ Scala │ 2.12.4-bin-typelevel-4 │ │ JavaScript │ Typelevel │ Scala │ Not available │ │ │ Scala.js │ Plug-in │ Not available │ ╰────────────┴──────────────┴──────────┴────────────────────────╯ ``` This is due to the fact that Scala.js supports Scala 2.13, and if all libraries are compatible, `choosePlatformConfiguration()` would choose 2.13 over 2.12. However, Typelevel Scala does not have a stable 2.13 release which is why the columns above state "Not available". Change `fetchCompilerVersions()` such that for all non-JVM platforms it filters out any Scala versions that are incompatible with the ones offered by the organisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Typelevel Scala 2.12.4 is used along with Scala.js, the latest
compiler version could not be determined during
seed update:This is due to the fact that Scala.js supports Scala 2.13, and if
all libraries are compatible,
choosePlatformConfiguration()wouldchoose 2.13 over 2.12. However, Typelevel Scala does not have a
stable 2.13 release which is why the columns above state "Not
available".
Change
fetchCompilerVersions()such that for all non-JVM platformsit filters out any Scala versions that are incompatible with the
ones offered by the organisation.