Ignores array types as far as Migrator is concerned #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a ecto type like {:array, :string} or {:array, :map} would
be fed into Code.ensure_loaded?/1, raising an argument error. While
it would be nice to be able to handle array types with encoded members,
ecto does not seem to handle the encoding to postgres nicely, and having
postgres report the field as an array of binaries leaks more information
than just having a binary type for the field and using Cloak.Ecto.Map to
wrap the data in a way that can be turned back into the list you want by
the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a ecto type like {:array, :string} or {:array, :map} would be fed into Code.ensure_loaded?/1, raising an argument error. While it would be nice to be able to handle array types with encoded members, ecto does not seem to handle the encoding of arrays of binaries to postgres nicely, and having the database report the field as an array of binaries leaks more information than just having a binary type for the field and using Cloak.Ecto.Map to wrap the data in a way that can be turned back into the list you want by the app.