Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private NPM auth (PoC) #1293

Closed

Conversation

rhyskoedijk
Copy link
Contributor

PoC to test fix for #685 (comment)

@rhyskoedijk rhyskoedijk marked this pull request as ready for review August 21, 2024 02:22
@rhyskoedijk rhyskoedijk marked this pull request as draft August 21, 2024 02:26
@rhyskoedijk
Copy link
Contributor Author

rhyskoedijk commented Aug 21, 2024

@mburumaxwell would it be possible to get a preview NPM image built and published for this feature branch for @DaleMckeown to re-test #685 (comment)?

I have tested this locally using my own private Azure DevOps NPM feed and the TL;DR; is that if I strip "https://" from the registry name when adding auth to .npmrc, it works. I am not sure if this is just a Azure DevOps quirk, or something that applies to all private NPM feeds, so I'm keen to see if it works for other users facing this issue.

@mburumaxwell
Copy link
Contributor

mburumaxwell commented Aug 23, 2024

I maybe wrong but I don't think this can work from a fork because of push permissions. You can try this by changing the conditions in the workflow so that the docker image is pushed.

The fastest/easiest way to test would be building and running the docker image locally.

@rhyskoedijk
Copy link
Contributor Author

Going to abandon this in favor of moving to dependabot-cli or similar. See #1317 (reply in thread) and #1318.

@rhyskoedijk rhyskoedijk closed this Sep 1, 2024
@rhyskoedijk rhyskoedijk deleted the feature/fix-npm-devops-auth branch September 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants