Fix bugs in initializing self.cnndm
in benchmark.py
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical change:
Below, lines 44 and 54 can cause an error due to
CNNDM
is undefined.And there is no need for the global variable
CNNDM
whenself.cnndm
presents.This bug fix uses only
self.cnndm
which is initialized toNone
. And when it isnone
,self.get_cnndm_documents()
orself.get_cnndm_references()
will populate it with real data.summac/summac/benchmark.py
Lines 41 to 56 in 9e4f357
Non-critical change:
This fix also exposes
cache_dir
of Huggingfacedatasets.load_datasets()
.