Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instant dismiss is not working #26

Closed
ligi opened this issue Dec 18, 2019 · 3 comments
Closed

instant dismiss is not working #26

ligi opened this issue Dec 18, 2019 · 3 comments

Comments

@ligi
Copy link

ligi commented Dec 18, 2019

snackProgressBarManager.show followed by an instant snackProgressBarManager.dismiss() or snackProgressBarManager.dismissAll() leads to dismiss not working as intended and the snack still being present.

@tingyik90
Copy link
Owner

tingyik90 commented Dec 18, 2019

Hi @ligi, really thank you for looking into this library. Yes, you are right, instant dismiss has been an issue since day 1 actually and I haven't a clue about why it happened, until now. Please see the latest commit 99edfdb. It should solve this issue now. Tested and working, but I look forward to your confirmation. Will release as 6.1.2 if working properly.

@ligi
Copy link
Author

ligi commented Dec 19, 2019

yes that works - please release 6.1.2 - would look nicer in my gradle files then ;-)

@tingyik90
Copy link
Owner

Thanks for the confirmation! Just to clarify #27 and I will release 6.2.0 instead, since #28 introduce some change to how the queue works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants