Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #25

Closed
wants to merge 5 commits into from
Closed

Build improvements #25

wants to merge 5 commits into from

Conversation

ligi
Copy link

@ligi ligi commented Dec 18, 2019

mainly wanted the "attach resources" and did the other stuff in the process

@tingyik90
Copy link
Owner

Hi @ligi, thanks for this pull request! But I am rather reluctant to use gradle 6.0.1 since the latest stable is 5.4.1. I've upgraded gradle in commit 60d2891.

Other changes that you made are for the app section, which is not really a concern since that is for demo purpose only.

@tingyik90 tingyik90 closed this Dec 18, 2019
@ligi
Copy link
Author

ligi commented Dec 18, 2019

thanks for looking into this. Do not yet understand where 5.4.1 is the latest stable - AFAIK it is 6.0.1: https://github.com/gradle/gradle/releases
Anyway - do not care for the gradle version that much - but really want attached sources.

@tingyik90
Copy link
Owner

I'm looking at https://developer.android.com/studio/releases/gradle-plugin#updating-gradle, where there seems to be a limit up to gradle 5.6.4. So I'd like to keep it as default that is suggested by Android Studio.

As for attached sources, I'm not familiar with what a7e3136 will generate. Do you mind pointing out some explanation of what it does? Sorry about that as I'm not familiar with gradle besides of what I normally use. I'll look into it this week as it's 2 AM local time now. Thanks.

@ligi
Copy link
Author

ligi commented Dec 18, 2019

it publishes the sources as artifacts - so when consuming the library I can click on the function and see the sources - quite important to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants