Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade protobuf-java #38

Closed
wants to merge 1 commit into from
Closed

Downgrade protobuf-java #38

wants to merge 1 commit into from

Conversation

pkoenig10
Copy link
Contributor

@wayneguow wayneguow mentioned this pull request Jul 8, 2024
Closed
@morambro
Copy link
Contributor

Hi pkoenig10, apologies for not seeing this PR before submitting 9fdb4e2 :( We downgraded protobuf exactly as in this PR. We are considering a patch release.

@morambro morambro closed this Jul 18, 2024
@pkoenig10
Copy link
Contributor Author

pkoenig10 commented Jul 18, 2024 •
edited
Loading

Not a problem. I would definitely appreciate a release with this downgrade.

@pkoenig10 pkoenig10 deleted the protobuf branch July 18, 2024 12:18
@pkoenig10 pkoenig10 mentioned this pull request Sep 9, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Sep 9, 2024
@pkoenig10 @copybara-github
Merge #44 by pkoenig10
1515388 
Upgrade protobuf-java

Fixes #31

Follow up to #38.

`protobuf-java` 4.28.0 has restored binary compatibility with classes generated using 3.x in protocolbuffers/protobuf#17913.

Closes ##44

COPYBARA_INTEGRATE_REVIEW=#44 from pkoenig10:protobuf 24a4999
PiperOrigin-RevId: 672542149
Change-Id: I586ab09c8e48859065a62b5a8a8f094c1a7d81ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkoenig10 @morambro