Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

No instructions for building Java JARs from the source? #136

Closed
mouse07410 opened this issue Sep 28, 2018 · 6 comments
Closed

No instructions for building Java JARs from the source? #136

mouse07410 opened this issue Sep 28, 2018 · 6 comments

Comments

@mouse07410
Copy link

You told how to get from Maven JARs that you built.

How do I build those JARs from the source?
@thaidn
Copy link
Contributor

thaidn commented Oct 3, 2018

Hi there,

There's some instruction here: https://github.com/google/tink/blob/master/docs/JAVA-HACKING.md.

@thaidn
Copy link
Contributor

thaidn commented Oct 3, 2018

You probably need the latest Bazel.

@mouse07410
Copy link
Author

I got the latest stable Bazel.

@thaidn
Copy link
Contributor

thaidn commented Oct 3, 2018

Does it work?

@mouse07410
Copy link
Author

Haven't tried yet. Also, the .md title suggests that it's not a straightforward/clean process? So far I've had enough trouble with what's supposed to be a "normal" (aka "non-hacking") build for C++. I'm not really itching to dive into hacking Java code under Bazel.

thaidn added a commit that referenced this issue Oct 4, 2018
@thaidn
Fix a bug that allows to compile Tink for Java with Bazel 0.17.2 (lat…
91b6f87 
…est).

Kokoro hasn't failed because its macOS and Ubuntu machines are using old Bazel versions.

Related issues:
#131
#136
bazelbuild/bazel#5997
bazelbuild/bazel#5594

PiperOrigin-RevId: 215787620
GitOrigin-RevId: 7b978f1374938e4b839f8357fc50d36b7ab96be5
@thaidn
Copy link
Contributor

thaidn commented Oct 4, 2018

@mouse07410 I just tested and confirm that compiling should work with latest Bazel (0.17.2).

The process is pretty straight-forward. Please reopen if you have any further questions or issues.

Cheers :)

@thaidn thaidn closed this as completed Oct 4, 2018
chuckx pushed a commit that referenced this issue Oct 10, 2018
@thaidn @chuckx
Fix a bug that allows to compile Tink for Java with Bazel 0.17.2 (lat…
8699e54 
…est).

Kokoro hasn't failed because its macOS and Ubuntu machines are using old Bazel versions.

Related issues:
#131
#136
bazelbuild/bazel#5997
bazelbuild/bazel#5594

PiperOrigin-RevId: 215787620
GitOrigin-RevId: 7b978f1374938e4b839f8357fc50d36b7ab96be5
chuckx pushed a commit that referenced this issue Oct 12, 2018
@thaidn @chuckx
Fix a bug that allows to compile Tink for Java with Bazel 0.17.2 (lat…
04febf6 
…est).

Kokoro hasn't failed because its macOS and Ubuntu machines are using old Bazel versions.

Related issues:
#131
#136
bazelbuild/bazel#5997
bazelbuild/bazel#5594

PiperOrigin-RevId: 215787620
GitOrigin-RevId: 7b978f1374938e4b839f8357fc50d36b7ab96be5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thaidn @mouse07410