update dependencies (tink) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqdeng
force-pushed
the
update-dependencies
branch
2 times, most recently
from
7d5e9c3 to
6f5500d
Compare
Signed-off-by: Kelly Deng <kelly@packet.com>
kqdeng
force-pushed
the
update-dependencies
branch
from
6f5500d to
f4280ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 24.40% 24.40%
=======================================
Files 5 5
Lines 504 504
=======================================
Hits 123 123
Misses 359 359
Partials 22 22
Continue to review full report at Codecov.
|
gianarb
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kelly Deng kelly@packet.com
Description
Following the merge of tinkerbell/tink#345, the
github/tinkerbell/tinkdependency ingo.modneeds to be updated to point to the latest master.Why is this needed
The PR tinkerbell/tink#345 updated the protobuf files and as a result, hegel (still importing an older version of tink) can no longer properly communicate with the latest version of tink.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: