Send container logs to syslog server #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
add-logging
branch
from
9874ac2
to
3ea93d3
Compare
… container: The `docker` alias wasn't available in the getty container. A bind mount was needed in the getty definition. Also, added the `docker-shell` alias to easily be able to get a shell in the DinD container for troubleshooting. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This sends all DinD container logs (tink-worker, workflow containers) to the syslog server that Boots currently runs. The kernel commandline arg `syslog_host` is parsed and used for the syslog destination. This will allow failed workflow logs to be available in Boots and not require users to access the machines console. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
add-logging
branch
from
3ea93d3
to
8ee5114
Compare
|
There's nothing boots specific in the PR so I'd suggest rewording to "a syslog host" and thats not so bad now :). |
jacobweinstock
changed the title
mmlb
reviewed
Apr 26, 2022
Comment on lines
+26
to
+27
| binds.add: | ||
| - /etc/profile.d/local.sh:/etc/profile.d/local.sh |
There was a problem hiding this comment.
nice find, this had been annoying me so much!
mmlb
approved these changes
Apr 26, 2022
jacobweinstock
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
8 tasks
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the only way to see container logs for workflows is to access the console of a machine. This makes troubleshooting difficult. This PR sends the tink-worker and workflow container logs back to aSyslog host.
Why is this needed
Fixes: #81
Fixes: #86
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: