Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose quickstart breaks with ERROR: Invalid interpolation format for "tls-gen" option in service "services": "${FACILITY:-onprem}" #118

Closed
dch opened this issue Nov 28, 2021 · 4 comments · Fixed by #154
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@dch
Copy link

dch commented Nov 28, 2021

Expected Behaviour

$ docker-compose up -d
Creating network "compose_default" with the default driver
Creating volume "compose_postgres_data" with default driver
Creating volume "compose_certs" with default driver
Creating volume "compose_auth" with default driver
Pulling tls-gen (cfssl/cfssl:)...
latest: Pulling from cfssl/cfssl
* woot * ** party parrot **

Current Behaviour

$ docker-compose up -d
ERROR: Invalid interpolation format for "tls-gen" option in service "services": "${FACILITY:-onprem}"

Possible Solution

I think the precise version docker-compose needs to be specified. 2.x is already public, 1.26 is too old, and 1.29.2 works for me.

$ curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

Steps to Reproduce (for bugs)

$ curl -L "https://github.com/docker/compose/releases/download/1.26/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose

Context

I was trying the simplest way to get to a running tinkerbell setup, assuming that docker-compose might be a good starting point.

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

using an ubuntu 20.04.3 LTS VM.

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

ubuntu vm

  • Link to your project or a code example to reproduce issue:

n/a

@tstromberg tstromberg added the kind/support Categorizes issue or PR as a support question. label Nov 30, 2021
@jacobweinstock
Copy link
Member

Hey @dch, thanks for reporting this. Were you following this guide by chance? https://github.com/tinkerbell/sandbox/blob/main/docs/quickstarts/COMPOSE.md
It does mention a docker-compose version requirement, but maybe we need to present that in a different way.

@dch
Copy link
Author

dch commented Dec 2, 2021 via email

@jacobweinstock
Copy link
Member

Hey @dch. Based on your experience here, would you be willing to provide any feedback on what we could do to make the docker-compose version requirement more apparent?

@Akucina
Copy link

Akucina commented Apr 24, 2022

I had similar error prompt while running: docker-compose ps

Later, realized that I did not run: cd /vagrant/compose first.

/vagrant is Synced Folder defined in Vagrant file:

provisioner.vm.synced_folder '../', '/vagrant'

@jacobweinstock jacobweinstock mentioned this issue Oct 5, 2022
3 tasks
@jacobweinstock jacobweinstock linked a pull request Oct 5, 2022 that will close this issue
3 tasks
mergify bot added a commit that referenced this issue Oct 25, 2022
## Description


This PR brings up the sandbox via Docker compose using the Kubernetes backend for all service. This does not completely remove the postgres backend setup but moves all the compose with postgres into an isolated directory (deploy/compose/postgres) that can be removed when we're ready. 

> I did not touch the terraform setup. I need some help validating that one. please and thank you. CC @mmlb @displague

## Why is this needed



Fixes: #142 #45 #118 #131 #133 #145 #148 
- This "fixes" a quite a few issues related to TLS cert generation. This is the case because we are not using TLS in this deployment. Also see, tinkerbell/tink#555.
- This also "fixes" any issues related to the internal registry as that is removed as the default.

## How Has This Been Tested?



Manually tested vagrant with virtualbox (on a Mac), vagrant with libvirt (on Ubuntu 22.04), and docker-compose (on on Ubuntu 22.04). 


## How are existing users impacted? What migration steps/scripts do we need?
There is no migration support. Users will need to follow a quick start guide to get started.





## Checklist:

I have:

- [x] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@mergify mergify bot closed this as completed in #154 Oct 25, 2022
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this issue Sep 7, 2024
## Description


This PR brings up the sandbox via Docker compose using the Kubernetes backend for all service. This does not completely remove the postgres backend setup but moves all the compose with postgres into an isolated directory (deploy/compose/postgres) that can be removed when we're ready. 

> I did not touch the terraform setup. I need some help validating that one. please and thank you. CC @mmlb @displague

## Why is this needed



Fixes: tinkerbell#142 tinkerbell#45 tinkerbell#118 tinkerbell#131 tinkerbell#133 tinkerbell#145 tinkerbell#148 
- This "fixes" a quite a few issues related to TLS cert generation. This is the case because we are not using TLS in this deployment. Also see, tinkerbell/tink#555.
- This also "fixes" any issues related to the internal registry as that is removed as the default.

## How Has This Been Tested?



Manually tested vagrant with virtualbox (on a Mac), vagrant with libvirt (on Ubuntu 22.04), and docker-compose (on on Ubuntu 22.04). 


## How are existing users impacted? What migration steps/scripts do we need?
There is no migration support. Users will need to follow a quick start guide to get started.





## Checklist:

I have:

- [x] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants