Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New home for terraform setup (cp from tink repo) #13

Merged
merged 1 commit into from
Sep 10, 2020
Merged

New home for terraform setup (cp from tink repo) #13

merged 1 commit into from
Sep 10, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Sep 10, 2020

This is coming from the tink repo.

@gianarb gianarb assigned thebsdbox and unassigned thebsdbox Sep 10, 2020
New home for terraform setup (cp from tink repo)
680e9be 
This is coming from the tink repo.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@gianarb gianarb requested a review from thebsdbox September 10, 2020 14:17
@gianarb gianarb mentioned this pull request Sep 10, 2020
Merged
thebsdbox
thebsdbox approved these changes Sep 10, 2020
View reviewed changes
Copy link

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple code move, that has no strong dependancies from source to destination. This should be fine to move.

@gianarb gianarb removed the request for review from gauravgahlot September 10, 2020 14:27
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Sep 10, 2020
@gianarb gianarb merged commit 5f05561 into master Sep 10, 2020
@mmlb mmlb deleted the chore/terraform branch November 19, 2021 21:37
ttwd80 pushed a commit to ttwd80/tinkerbell-playground that referenced this pull request Sep 7, 2024
@gianarb
Merge pull request tinkerbell#13 from tinkerbell/chore/terraform
144b11a 
New home for terraform setup (cp from tink repo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees
No one assigned
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gianarb @thebsdbox