Add sleep to reduce logging output #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Titi Wangsa bin Damhore <ttwd80@gmail.com>
Signed-off-by: Titi Wangsa bin Damhore <ttwd80@gmail.com>
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
## Description
The command `kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'` is executed in a loop. When I run `vagrant up` the my screen is filled with:
```
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: ++ tr ' ' ,
stack: + trusted_proxies=
stack: + '[' '' '!=' '' ']'
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: ++ tr ' ' ,
stack: + trusted_proxies=
stack: + '[' '' '!=' '' ']'
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: ++ tr ' ' ,
stack: + trusted_proxies=
stack: + '[' '' '!=' '' ']'
```
## Why is this needed
To reduce the verbosity.
## How Has This Been Tested?
Tested on my on machine. It worked before the change. It worked after the change with less output.
```
stack: + local loadbalancer_ip=192.168.56.5
stack: + trusted_proxies=
stack: + '[' '' '!=' '' ']'
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: ++ tr ' ' ,
stack: + trusted_proxies=
stack: + sleep 5
stack: + '[' '' '!=' '' ']'
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: ++ tr ' ' ,
stack: + trusted_proxies=
stack: + sleep 5
stack: + '[' '' '!=' '' ']'
stack: ++ tr ' ' ,
stack: ++ kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'
stack: + trusted_proxies=10.42.0.0/24
stack: + sleep 5
stack: + '[' 10.42.0.0/24 '!=' '' ']'
stack: + helm install tink-stack oci://ghcr.io/tinkerbell/charts/stack --version 0.4.5 --create-namespace --namespace tink-system --wait --set 'smee.trustedProxies={10.42.0.0/24}' --set 'hegel.trustedProxies={10.42.0.0/24}' --set stack.kubev
```
## How are existing users impacted? What migration steps/scripts do we need?
N/A
## Checklist:
I have:
- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The command
kubectl get nodes -o 'jsonpath={.items[*].spec.podCIDR}'is executed in a loop. When I runvagrant upthe my screen is filled with:Why is this needed
To reduce the verbosity.
How Has This Been Tested?
Tested on my on machine. It worked before the change. It worked after the change with less output.
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have: