Fix tftp ReadFile, Add tests: #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tftp ReadFile was missing a return if AllowPxe was false. This adds the return and adds tests for the AllowPxe gate that was just recently added. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 40.65% 42.52% +1.86%
==========================================
Files 40 40
Lines 2086 2086
==========================================
+ Hits 848 887 +39
+ Misses 1152 1113 -39
Partials 86 86
Continue to review full report at Codecov.
|
|
I don't know what that library is used for, but it is archived... We should figure out an alternative I suppose at some point |
gianarb
approved these changes
Mar 12, 2021
mmlb
reviewed
Mar 12, 2021
|
|
||
| for name, tc := range tests { | ||
| t.Run(name, func(t *testing.T) { | ||
| monkey.Patch(job.CreateFromRemoteAddr, func(_ string) (job.Job, error) { |
mmlb
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tftp ReadFile was missing a return if AllowPxe was false.
This adds the return and adds tests for the AllowPxe
gate that was just recently added.
this library: https://github.com/bouk/monkey, was used in the unit tests and requires running tests with
-gcflags=-l.the github actions were updated to accommodate this.
a few testing helpers were added to the makefile.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: