Revert "add support for UEFI HTTP Boot" #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ceb470a. Something in tinkerbell#216 broke our c2.large.arm provisions. Reverting this to unblock things that came after while I look into debugging. Some more info in [tinkerbell#225]. [tinkerbell#225]: tinkerbell#225 Signed-off-by: Manuel Mendez <mmendez@equinix.com>
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 38.87% 38.95% +0.07%
==========================================
Files 41 41
Lines 2765 2765
==========================================
+ Hits 1075 1077 +2
+ Misses 1604 1602 -2
Partials 86 86
Continue to review full report at Codecov.
|
jacobweinstock
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit ceb470a.
Why is this needed
Something in #216 broke our c2.large.arm provisions. Reverting
this to unblock things that came after while I look into debugging.
Some more info in #225.
How Has This Been Tested?
Tested via sandbox against EM c2.large.arm