pass tink server tls mode as kernel cmdline arg #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows flexibility from where to pull the tink worker image. This will be needed if the env var 'DOCKER_REGISTRY` is not specified. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This allows TLS communication with Tink server to be toggled by Tink worker. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
changed the title
jacobweinstock
changed the title
New version has the new TLS settings needed and fixes a panic in the TinkHardwareClient calls. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
|
This is now in main via #258 see https://github.com/tinkerbell/boots/blob/main/installers/osie/main.go#L65. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows TLS communication with Tink server to be toggled by Tink worker.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: