Skip to content

Commit

Permalink
Require all reviews to be approved
Browse files Browse the repository at this point in the history
This way we ensure one set of reviews doesn't override a different set
of reviews by someone else. All reviewers should have their concerns
addressed before merging.
  • Loading branch information
mmlb committed Jun 4, 2020
1 parent 71a54a5 commit 12dc8b6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ pull_request_rules:
conditions:
- base=master
- "#approved-reviews-by>=1"
- "#review-requested=0"
- "#changes-requested-reviews-by=0"
- "#commented-reviews-by=0"
- label=ready-to-merge
- label!=hold-off-merging
actions:
Expand Down

0 comments on commit 12dc8b6

Please sign in to comment.