Skip to content

Commit

Permalink
Remove Tink worker global timeout cli flag:
Browse files Browse the repository at this point in the history
The Tink worker global timeout cli flag doesn't implement
the global timeout defined in a Tink server template correctly.

A single template can have multiple workers. So a single
Tink worker defining a global timeout for all task is
erroneous. It doesn't take the multiple workers idea into account.

A long term solution will need to be implemented. Something that
takes into account multiple workers.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
  • Loading branch information
jacobweinstock committed Apr 11, 2022
1 parent 08a2e12 commit e935a37
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cmd/tink-worker/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ func NewRootCommand(version string, logger log.Logger) *cobra.Command {

ctx := context.Background()
if timeOut > 0 {
var cancel context.CancelFunc
ctx, cancel = context.WithTimeout(ctx, timeOut)
defer cancel()
logger.Info("timeOut is deprecated")
}

conn, err := tryClientConnection(logger, retryInterval, retries)
Expand Down

0 comments on commit e935a37

Please sign in to comment.