Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"tink workflow get/get by id" command returns the incorrect state for workflows #477

Closed
parauliya opened this issue Apr 8, 2021 · 0 comments · Fixed by #482
Closed

"tink workflow get/get by id" command returns the incorrect state for workflows #477

parauliya opened this issue Apr 8, 2021 · 0 comments · Fixed by #482

Comments

@parauliya
Copy link
Contributor

"tink workflow get/get by id" command returns the incorrect state for workflows.
Right now it always returns state as STATE_PENDING for all the workflows which is incorrect because if a workflow is running it should have state as STATE_RUNNING and if finished successfully, it should have state as STATE_SUCCESSFUL.

Expected Behaviour

"tink workflow get/get by id" command should return the current state for workflows.

Current Behaviour

Right now it always returns state as STATE_PENDING for all the workflows which is incorrect.

Possible Solution

Update the workflow state as soon as it started/finished/failed.

  • Operating System Linux (Ubuntu 1804):

  • How are you running Tinkerbell: Using Vagrant & VirtualBox
parauliya pushed a commit to parauliya/tink that referenced this issue Apr 14, 2021
Fixed tinkerbell#477 : Corrected state for get and get by id command.
5f1b80d 
Signed-off-by: parauliya <aman@infracloud.io>
@parauliya parauliya mentioned this issue Apr 14, 2021
Merged
3 tasks
parauliya pushed a commit to parauliya/tink that referenced this issue Apr 20, 2021
Fixed tinkerbell#477 : Corrected state for get and get by id command.
d1ca1bf 
Signed-off-by: parauliya <aman@infracloud.io>
parauliya added a commit that referenced this issue Apr 20, 2021
@parauliya
Merge pull request #482 from parauliya/Fix_477
5d58c4b 
Fixed #477 : Corrected state for get and get by id command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #477 : Corrected state for get and get by id command. parauliya/tink
1 participant
@parauliya