Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to PostgreSQL 14 #551

Closed
rgl opened this issue Oct 10, 2021 · 1 comment · Fixed by #552 or tinkerbell/playground#110
Closed

Migrate to PostgreSQL 14 #551

rgl opened this issue Oct 10, 2021 · 1 comment · Fixed by #552 or tinkerbell/playground#110
Labels
ready-to-merge Signal to Mergify to merge the PR.
Milestone
0.7.0

Comments

@rgl
Copy link
Contributor

rgl commented Oct 10, 2021

It would be nice to upgrade to PostgreSQL 14.

Besides all the major improvements made from PostgreSQL 10 to 14, there is one particular feature that I wanted to use:

A nicer way to work with JSON, like the hardware data model :-)
@mmlb
Copy link
Contributor

mmlb commented Oct 11, 2021

sgtm, I'd say you should update the docker-compose here along with the files in sandbox repo.

This was referenced Oct 12, 2021
Merged
Merged
@ScottGarman ScottGarman added the ready-to-merge Signal to Mergify to merge the PR. label Nov 2, 2021
mergify bot added a commit that referenced this issue Nov 2, 2021
@mergify
Upgrade to PostgreSQL 14 (#552)
187a3c7 
## Description

Upgrade to PostgreSQL 14.

## Why is this needed

Besides all the major improvements made from PostgreSQL 10 to 14, there is one particular feature that I wanted to use:

[A nicer way to work with JSON](https://www.postgresql.org/docs/14/datatype-json.html#JSONB-SUBSCRIPTING), like the hardware data model :-)

Fixes: #551

The sandbox MR is at tinkerbell/playground#110.

## How Has This Been Tested?

Besides the unit tests executed by CI, I've successfully tested this locally in a sandbox, and PostgreSQL 14 is now running:

```console
root@provisioner:~# docker exec -i compose-db-1 psql -U tinkerbell -A -c 'select version()'
version
PostgreSQL 14.0 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424, 64-bit
(1 row)
```

## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Upgrade to PostgreSQL 14 rgl/tinkerbell-tink
Upgrade to PostgreSQL 14 rgl/tinkerbell-sandbox
4 participants
@rgl @ScottGarman @displague @mmlb