Add version subcommand #94
Labels
priority/backlog
Higher priority than priority/awaiting-more-evidence.
size/S
estimate of the amount of work to address the issue
Comments
thebsdbox
added
fix-required
priority/backlog
mergify bot
added a commit
that referenced
this issue
Aug 19, 2020
## Description * Fixes testing via Makefile `make test` (did not test anything before) * Fixes #94 based on the git SHA and eventual git tags (blocked by #74) * Adds `tink-cli --version` output * Because `tink-server` and `tink-worker` do not currently take parameters, the version is now emitted at start. * `tink-server` emits this at INFO level (because it is a long-lived process) * `tink-worker` emits this at DEBUG level (because the default run is quiet, afaict) * Adds a `tink-cli completion` subcommand <!--- Please describe what this PR is going to change --> ## Why is this needed <!--- Link to issue you have raised --> Fixes: #94 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> * `tink-cli completion --help` * `tink-cli completion bash` * ``` cmd/tink-cli/tink-cli --version tink version f9500b2 ``` * ``` PACKET_VERSION="x" PACKET_ENV="t" ROLLBAR_TOKEN="t" cmd/tink-server/tink-server {"level":"info","ts":1597460174.581983,"caller":"tink-server/main.go:30","msg":"starting version f9500b2","service":"github.com/tinkerbell/tink"} {"level":"info","ts":1597460174.582356,"caller":"metrics/metrics.go:58","msg":"initializing label values","service":"github.com/tinkerbell/tink"} ``` * ``` TINKERBELL_CERT_URL="l" PACKET_VERSION="x" PACKET_ENV="t" ROLLBAR_TOKEN="t" WORKER_LOG_LEVEL=debug cmd/tink-worker/tink-worker DEBU[0000] Starting version f9500b2 INFO[0000] RETRY_INTERVAL not set. Using default, 3 seconds INFO[0000] MAX_RETRY not set. Using default, 3 retries. FATA[0000] fetch cert: Get "l": unsupported protocol scheme "" ``` ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With
tinkbinary, it should be possible to check version of both CLI tool and ideally server, similar tokubectl versionfunctionality, as currently, there is no way to reference which version of the binary is in use when reporting the issues.The text was updated successfully, but these errors were encountered: