Move tink-server deploy/db files into top-level deploy dir #117
Conversation
|
I split them like this since tink-server/Dockerfile was adding them. I thought tink-server had an entrypoint script that would run migrations. That isn't the case though. |
mmlb
force-pushed
the
fix-db-setup-post-cmd-move
branch
2 times, most recently
from
6e389cc to
29d8cde
Compare
|
Good to see a fix for this. When do we think this PR could get merged? Looks like a few people (and now me, are running into this)
|
| restart: unless-stopped | ||
| environment: | ||
| POSTGRES_DB: tinkerbell | ||
| POSTGRES_PASSWORD: tinkerbell | ||
| POSTGRES_USER: tinkerbell | ||
| volumes: | ||
| - ./db/tinkerbell-init.sql:/docker-entrypoint-initdb.d/tinkerbell-init.sql:ro |
There was a problem hiding this comment.
I'm not actually finding a local folder called db in the deploy folder after running setup.sh?
There was a problem hiding this comment.
Because setup.sh fetches from master. I commented out the git fetch bit and used my own clone of this pr and it worked out fine.
|
If anyone else is landing here run: Then paste in from https://raw.githubusercontent.com/tinkerbell/tink/29d8cde68c019de76c40bc6ffaebf60209c2e5a8/deploy/db/tinkerbell-init.sql |
tink-server does not do anything with these files currently. These files really do belong in the tink-server container image but we need better migration handling -server before these file can come into it.
mmlb
force-pushed
the
fix-db-setup-post-cmd-move
branch
from
29d8cde to
6f45222
Compare
|
Hi @gauravgahlot @mmlb , This PR needs to be merged asap, without this PR setup script will not work since |
|
Yep looking for some review. |
|
I just ran through tf and setup off this branch and it all worked out. Can I get a 👍 @parauliya, @nathangoulding, @mikemrm |
|
Thanks @mmlb 💪 |
tink-server does not do anything with these files currently. These files
really do belong in the tink-server container image but we need better
migration handling -server before these file can come into it.