Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespell fixes #154

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Codespell fixes #154

merged 4 commits into from
Jun 4, 2020

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jun 4, 2020

Fixes spelling mistakes and add codespell to ci so won't happen again.

Like aspell, but for code. So great.
@mmlb mmlb requested a review from grahamc June 4, 2020 18:33
grahamc
grahamc previously approved these changes Jun 4, 2020
db/workflow.go Outdated Show resolved Hide resolved
@mmlb mmlb force-pushed the codespell-fixes branch from fe9593c to ac49ae2 Compare June 4, 2020 18:46
@mmlb mmlb requested a review from grahamc June 4, 2020 18:47
grahamc
grahamc previously approved these changes Jun 4, 2020
mmlb added 2 commits June 4, 2020 14:51
Along with some valid mispellings to a whitelist.
@mmlb mmlb force-pushed the codespell-fixes branch from ac49ae2 to 50b29f5 Compare June 4, 2020 18:52
@mmlb mmlb requested a review from grahamc June 4, 2020 18:52
Copy link
Contributor

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay but I'm merging it this time 😂

@grahamc grahamc added the ready-to-merge Signal to Mergify to merge the PR. label Jun 4, 2020
@mergify mergify bot merged commit 7b55e2d into tinkerbell:master Jun 4, 2020
@mmlb mmlb deleted the codespell-fixes branch September 30, 2020 21:42
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants