Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style issue with error strings #160

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Style issue with error strings #160

merged 1 commit into from
Jun 8, 2020

Conversation

RafaelAnsay
Copy link
Contributor

@RafaelAnsay RafaelAnsay commented Jun 6, 2020 •
edited
Loading

Fixes #56

@RafaelAnsay RafaelAnsay changed the title Style issue with error strings #56 Style issue with error strings Jun 7, 2020
gauravgahlot
gauravgahlot approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added ready-to-merge Signal to Mergify to merge the PR. and removed fix-required labels Jun 8, 2020
@mergify mergify bot merged commit 8e7e170 into tinkerbell:master Jun 8, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

Assignees

@RafaelAnsay RafaelAnsay

@gauravgahlot gauravgahlot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style issue with error strings
3 participants
@RafaelAnsay @gauravgahlot @mmlb