ci-checks: run all the checks on checked-in files; check shellcheck #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmlb do you think it is worth adding |
|
I'm fine with adding git to shell.nix. The shell.nix's aren't super pure for the projects and I've kind of wanted to move towards that way as much as possible where it makes sense. |
Don't run on files which are not being committed, and run all the checks even if one step failed
mmlb
approved these changes
Jun 17, 2020
| if [ $? -eq 0 ]; then | ||
| break | ||
| fi | ||
| while ! docker login -u username -p password localhost; do |
There was a problem hiding this comment.
Does this really belong in this PR? I'm fine if you want to earmark it in, just wand to double check.
There was a problem hiding this comment.
Maybe not, it just seemed like the easiest fix for $i being unused. I could swap it out to just echo the iteration. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run on files which are not being committed, and run all
the checks even if one step failed.
This PR should fail (validating that the CI check still fails) and then I will add additional commits fixing its complaints.