chore: expose tink server via Vagrant port forward #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
added
area/setup
I am working at the e2e test for the vagrant setup. It is very useful to be able to reach tink-server from outside the VM because that where the logic that asserts the right execution lives. It is also good for experimentation because I was able to build the tink cli: ``` go build -o tink ./cmd/tink-cli/main.go ``` I was able to use the tink cli from my local environment. Way more familiar that `docker exec` as a workflow imho: ``` $ TINKERBELL_GRPC_AUTHORITY=127.0.0.1:42113 TINKERBELL_CERT_URL=http://127.0.0.1:42114/cert ./tink hardware list +----+-------------+------------+----------+ | ID | MAC ADDRESS | IP ADDRESS | HOSTNAME | +----+-------------+------------+----------+ +----+-------------+------------+----------+ ```
gauravgahlot
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am working at the e2e test for the vagrant setup. It is very useful to
be able to reach tink-server from outside the VM because that where the
logic that asserts the right execution lives.
It is also good for experimentation because I was able to build the tink
cli:
I was able to use the tink cli from my local environment. Way more
familiar that
docker execas a workflow imho:Why is this needed
it is more friendly to use and it helps me writing e2e tests #169