Skip to content
This repository was archived by the owner on Dec 2, 2025. It is now read-only.

Conversation

@gauravgahlot
Copy link
Contributor

Description

The PR fixes the return type for template validation functions.

Reference thread here.

How Has This Been Tested?

Unit tests.

How are existing users impacted? What migration steps/scripts do we need?

No impact.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot gauravgahlot self-assigned this Sep 9, 2020
@gauravgahlot gauravgahlot changed the title Corrected returns for validations Corrected return type for validators Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #284 into master will decrease coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   20.61%   19.97%   -0.65%     
==========================================
  Files          15       15              
  Lines        1363     1352      -11     
==========================================
- Hits          281      270      -11     
  Misses       1068     1068              
  Partials       14       14              
Impacted Files Coverage Δ
pkg/template_validator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aef424...458814f. Read the comment docs.

@gauravgahlot gauravgahlot deleted the right-returns branch September 9, 2020 06:11
@gauravgahlot gauravgahlot added triage/duplicate Indicates an issue is a duplicate of other open issue. and removed fix-required labels Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

triage/duplicate Indicates an issue is a duplicate of other open issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant