Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker-compose to image build. #302

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Move docker-compose to image build. #302

merged 2 commits into from
Sep 21, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Sep 21, 2020

This docker-compose file is used for development purpose. It sounds
more useful if it builds the actual image.

@gianarb gianarb requested a review from mmlb September 21, 2020 13:57
This docker-compose file is used for development purpose. It sounds
more useful if it builds the actual image.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #302 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          15       15           
  Lines        1275     1275           
=======================================
  Hits          292      292           
  Misses        964      964           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b9338...bfd44d0. Read the comment docs.

@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Sep 21, 2020
@mergify mergify bot merged commit fb06ccd into tinkerbell:master Sep 21, 2020
@gianarb gianarb deleted the chore/docker-build branch September 21, 2020 14:43
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants