Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tink CLI errors now end with a newline #337

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Oct 10, 2020

Description

With this change, the CLI errors will now end with a newline. Therefore, making it easier for a user to read the error message.

Why is this needed

Fixes: #336

How Has This Been Tested?

Tested on the local vagrant setup.

/ # tink hardware id
Error: requires at least one id
Usage:
  tink hardware id [flags]

Examples:
tink hardware id 224ee6ab-ad62-4070-a900-ed816444cec0 cb76ae54-93e9-401c-a5b2-d455bb3800b1

Flags:
  -h, --help   help for id

Global Flags:
  -f, --facility string   used to build grpc and http urls

requires at least one id
/ # 

How are existing users impacted? What migration steps/scripts do we need?

It's easier to read the error message now.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   23.79%   23.79%           
=======================================
  Files          14       14           
  Lines        1244     1244           
=======================================
  Hits          296      296           
  Misses        928      928           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4606f1e...1cd2e23. Read the comment docs.

@gauravgahlot gauravgahlot added the size/XS estimate of the amount of work to address the issue label Oct 10, 2020
@gauravgahlot gauravgahlot self-assigned this Oct 10, 2020
@gauravgahlot gauravgahlot requested a review from gianarb October 10, 2020 15:31
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to Me.

@gauravgahlot gauravgahlot removed the request for review from gianarb October 10, 2020 16:50
@mergify mergify bot merged commit 3427566 into tinkerbell:master Oct 10, 2020
@gauravgahlot gauravgahlot deleted the newline branch October 10, 2020 16:51
@invidian
Copy link
Contributor

Thanks!

@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest size/XS estimate of the amount of work to address the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printed Tink CLI errors do not end with newline which produces annoying output
4 participants