Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CII Best Practices Badge #384

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Dec 11, 2020

Closes: #374

@gauravgahlot gauravgahlot self-assigned this Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #384 (85eb982) into master (9ed69b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   28.71%   28.71%           
=======================================
  Files          19       19           
  Lines        1386     1386           
=======================================
  Hits          398      398           
  Misses        961      961           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed69b7...85eb982. Read the comment docs.

@gauravgahlot gauravgahlot force-pushed the cii-badge branch 2 times, most recently from aa0f656 to 5283ce1 Compare December 11, 2020 10:38
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Dec 11, 2020
@gianarb
Copy link
Contributor

gianarb commented Dec 11, 2020

Screenshot 2020-12-11 at 13 01 11

Thank you for your contribution! Do you know why there are 2 tink projects submitted that look the same?
And there a few sticks that IMHO should be green, like the documentation for an example. Is it something that has to be submitted? Same for the information about how to contribute.

if you can add more owners please add me in

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot
Copy link
Contributor Author

@gianarb

  • I have removed the duplicate project. That was because I had submitted tink like a month ago and I forgot it. So I unknowingly resubmitted it.
  • Yeah, there are a few that should be green and can be marked manually. So, I will do that. Maybe we can get on a call and do it at once.
  • I don't see an option to add another owner.

@gianarb gianarb removed the request for review from thebsdbox December 14, 2020 08:32
@mergify mergify bot merged commit 492f9c7 into tinkerbell:master Dec 14, 2020
@gauravgahlot gauravgahlot deleted the cii-badge branch December 14, 2020 08:37
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get a passing CII Best Practices Badge
3 participants