Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for db package #409

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Conversation

gauravgahlot
Copy link
Contributor

Description

The PR adds unit tests for db package.

Why is this needed

Increased unit test coverage.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@gauravgahlot gauravgahlot self-assigned this Jan 4, 2021
@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #409 (086dda0) into master (ad5c929) will increase coverage by 8.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   21.38%   29.90%   +8.52%     
==========================================
  Files          24       24              
  Lines        2170     2170              
==========================================
+ Hits          464      649     +185     
+ Misses       1664     1445     -219     
- Partials       42       76      +34     
Impacted Files Coverage Δ
db/template.go 47.69% <0.00%> (+13.07%) ⬆️
db/workflow.go 26.53% <0.00%> (+26.32%) ⬆️
db/db.go 36.36% <0.00%> (+27.27%) ⬆️
db/hardware.go 30.27% <0.00%> (+30.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5c929...086dda0. Read the comment docs.

@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jan 4, 2021
@gauravgahlot gauravgahlot requested a review from gianarb January 4, 2021 06:23
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gianarb
Copy link
Contributor

gianarb commented Jan 4, 2021

Such a nice way to start in 2021!! Thanks a lot!

@mergify mergify bot merged commit 9f96b8b into tinkerbell:master Jan 4, 2021
@gauravgahlot gauravgahlot deleted the db-tests branch January 4, 2021 08:39
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants