Improve empty string test

[rayandas]

Signed-off-by: Rayan Das rayandas91@gmail.com

Description

A string can be tested for its emptiness either by treating it as a slice and calculating the length of the slice, or by treating it as a string and directly comparing the value. While both produce identical code when compiled, it makes more sense to treat a string as itself, than a slice, for the sake of comparison of values.

For example:

len(xyz) == 0

can be rewritten as:

xyz == ""

Why is this needed

The second method is considered more idiomatic.

[codecov]

Codecov Report

Merging #473 (b5064e9) into master (c25ee26) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b5064e9 differs from pull request most recent head 1dd406a. Consider uploading reports for the commit 1dd406a to get more accurate results

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   32.32%   32.32%           
=======================================
  Files          50       50           
  Lines        3276     3276           
=======================================
  Hits         1059     1059           
  Misses       2123     2123           
  Partials       94       94           

Impacted Files	Coverage Δ
grpc-server/tinkerbell.go	92.12% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25ee26...1dd406a. Read the comment docs.

[gauravgahlot]

@rayandas Could you please update the branch?

[rayandas]

@gauravgahlot updated.